fix(server): disable breakpoints correctly and avoid style overuse #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaerusKaru
force-pushed
the
adam/fix-issue-1065
branch
from
55960bb
to
9df0fa2
Compare
This problem is two-fold. First, on the server, when we deactivated breakpoints, we were deactivating them in the wrong order. This meant that after a breakpoint was activated, its styles would linger, polluting the correct state of the style map. The second problem was overpopulation of styles. Essentially, we would provide a fallback style for every single breakpoint if available. This is redundant, because we already populate a global activation state at the beginning of style population. To resolve these issues, we ensure that we deactivate breakpoints correctly, and we also disable fallback styles on the server after the initial population is complete.
CaerusKaru
force-pushed
the
adam/fix-issue-1065
branch
from
9df0fa2
to
d7e3aa8
Compare
This was referenced Dec 29, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem is two-fold. First, on the server, when we deactivated
breakpoints, we were deactivating them in the wrong order. This
meant that after a breakpoint was activated, its styles would
linger, polluting the correct state of the style map.
The second problem was overpopulation of styles. Essentially,
we would provide a fallback style for every single breakpoint
if available. This is redundant, because we already populate a
global activation state at the beginning of style population.
To resolve these issues, we ensure that we deactivate breakpoints
correctly, and we also disable fallback styles on the server after
the initial population is complete.
Fixes #1065