From 5b35e20aeb147b713c31ba5c269cf2128c746d46 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Mon, 14 Feb 2022 16:45:39 +0100 Subject: [PATCH] fix(bazel/karma): web test arguments not passed through Fixes that the webtest arguments are not passed through to the debug target. Also wires up the rule in our own tests as planned initially (now that the test is merged) --- bazel/browsers/test/BUILD.bazel | 2 +- bazel/karma/index.bzl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bazel/browsers/test/BUILD.bazel b/bazel/browsers/test/BUILD.bazel index 6beba8322..5e9e1f22a 100644 --- a/bazel/browsers/test/BUILD.bazel +++ b/bazel/browsers/test/BUILD.bazel @@ -1,5 +1,5 @@ load("@build_bazel_rules_nodejs//:index.bzl", "js_library") -load("@npm//@bazel/concatjs:index.bzl", "karma_web_test_suite") +load("//bazel/karma:index.bzl", "karma_web_test_suite") load("//bazel/spec-bundling:index.bzl", "spec_bundle") karma_web_test_suite( diff --git a/bazel/karma/index.bzl b/bazel/karma/index.bzl index 1ecb2598f..e8466b6cf 100644 --- a/bazel/karma/index.bzl +++ b/bazel/karma/index.bzl @@ -46,7 +46,7 @@ def karma_web_test_suite(name, **kwargs): # Custom standalone web test that can be run to test against any # browser that is manually connected to. - _karma_debug_browsers_target(name = "%s_debug" % name) + _karma_debug_browsers_target(name = "%s_debug" % name, **web_test_args) # Default test suite with all configured browsers. _karma_web_test_suite(name = name, **kwargs)