Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox): expose ripple instance #9176

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

devversion
Copy link
Member

@devversion devversion commented Dec 31, 2017

  • Exposes the reference to the MatRipple directive publically.

Similar to #9170. References #4179

* Exposes the reference to the `MatRipple` directive publically.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 31, 2017
@jelbourn
Copy link
Member

jelbourn commented Jan 2, 2018

This seems out of sync with the discussion in #4179, no?

@devversion
Copy link
Member Author

devversion commented Jan 3, 2018

The PR should resolve #4179. It's not the implementation of the last idea (with the mixins), which intends to provide another public API for the ripples.

In my opinion, if we should expose the ripple instance, then it should be really the MatRipple and no wrapper, that just provides a nicer API.

Since there is a overview file for the ripple now, I think that it would be fine just exposing the instance. Also, as I mentioned in #9170, we can add a guide that shows how to control ripples of components that expose the instance.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed pr: needs review labels Jan 12, 2018
@jelbourn jelbourn merged commit e09c0a6 into angular:master Jan 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants