From 92fce6642b073aad6a2264de5fe97759e9865336 Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Fri, 12 Mar 2021 09:04:56 +0100 Subject: [PATCH] build: run commit message check after other lint checks We recently had some lint failures slip into the main branch, because they had both commit message failures and other lint failures. The problem was that we sometimes ignore commit message failures since they can be fixed by the caretaker, but if the commit check fails, it prevents any other the other lint checks from running. These changes move the commit message check to be last in the `lint` job so that if it fails, we know that everything else is in a mergeable state. --- .circleci/config.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 145063a0ef3d..3eaf34914579 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -353,6 +353,13 @@ jobs: yarn check-entry-point-setup $(bazel info bazel-bin)/entry_points_manifest.json - run: yarn ng-dev format changed --check << pipeline.git.base_revision >> + - run: yarn ownerslint + - run: yarn check-mdc-tests + - run: yarn stylelint + - run: yarn tslint + - run: yarn -s ts-circular-deps:check + - run: yarn check-mdc-exports + # Should be last so that it doesn't prevent the other lint checks from running. - run: name: Check Commit Message (PR Only) # Only run the commit message checks on pull requests since we can't do @@ -361,12 +368,6 @@ jobs: if [ -n "$CIRCLE_PR_NUMBER" ]; then yarn ng-dev commit-message validate-range --range $CI_COMMIT_RANGE fi - - run: yarn ownerslint - - run: yarn check-mdc-tests - - run: yarn stylelint - - run: yarn tslint - - run: yarn -s ts-circular-deps:check - - run: yarn check-mdc-exports - *slack_notify_on_failure - *save_cache