Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement window breakpoints from Material guidelines #9212

Closed
odahcam opened this issue Jan 3, 2018 · 5 comments · Fixed by #9318
Closed

Implement window breakpoints from Material guidelines #9212

odahcam opened this issue Jan 3, 2018 · 5 comments · Fixed by #9318
Labels
help wanted The team would appreciate a PR from the community to address this issue

Comments

@odahcam
Copy link
Contributor

odahcam commented Jan 3, 2018

Bug, feature request, or proposal:

feature request

What is the expected behavior?

That BreakpointObserver has all Material guidelines breakpoints.

What is the current behavior?

BreakpointObserver has the handset breakpoints and the web breakpoints (which isn't in the guidelines).

What is the use-case or motivation for changing an existing behavior?

Be true to the Material guidelines specs and improve usability of the lib by allowing the user to not have to write more MediaMatcher code (media queries by hand) to achieve something in the guidelines.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular Material ^5.0.0

Is there anything else we should know?

Maybe a usefull image.

image

So the breakpoints could be:

Breakpoints += [ WindowXSmall, WindowSmall, WindowMedium, WindowLarge, WindowXLarge ]
@josephperrott
Copy link
Member

These breakpoints would be great to add to the breakpoints.ts file within @angular/cdk/layout.

@josephperrott josephperrott removed their assignment Jan 9, 2018
@josephperrott josephperrott added help wanted The team would appreciate a PR from the community to address this issue responsive labels Jan 9, 2018
@mackelito
Copy link

@josephperrott I see that they are in breakpoints.ts file but it would also be great to have it bettre explained in the docs :)

@odahcam
Copy link
Contributor Author

odahcam commented Feb 27, 2018

As longs as this is closed, I think a new issue would be more appropriated. 😉

@mackelito
Copy link

Sure.. but before polluting with new issues I just wanted to check here first. 😁

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The team would appreciate a PR from the community to address this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants