Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve focus-trap to optionally aria-disable everything outside the trapped region #9035

Closed
jelbourn opened this issue Dec 18, 2017 · 2 comments
Closed

Improve focus-trap to optionally aria-disable everything outside the trapped region #9035

jelbourn opened this issue Dec 18, 2017 · 2 comments
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) area: cdk/a11y feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release

Comments

@jelbourn
Copy link
Member

#9016 adds this behavior to the dialog specifically (so that it is a patch fix), but the underlying focus-trap should be expanded with this feature. This, however, would change how the API for focus-trap is structured and will need to go in a major version.
@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) feature This issue represents a new feature or feature request rather than a bug or bug fix target: major This PR is targeted for the next major release labels Dec 18, 2017
@jelbourn jelbourn added this to the 6.0 milestone Dec 18, 2017
@jelbourn jelbourn modified the milestones: 6.0, 7.0 Mar 7, 2018
@ngbot ngbot bot removed this from the 7.0 milestone Apr 25, 2018
@josephperrott josephperrott added this to the 7.0 milestone Apr 25, 2018
@mmalerba mmalerba added the needs triage This issue needs to be triaged by the team label May 20, 2020
@jelbourn jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: cdk/a11y and removed needs triage This issue needs to be triaged by the team labels May 25, 2020
@jelbourn jelbourn mentioned this issue May 28, 2020
Closed
@jelbourn jelbourn removed this from the 7.0 milestone May 28, 2020
@wagnermaciel wagnermaciel mentioned this issue May 28, 2020
Closed
@jelbourn jelbourn mentioned this issue Jun 4, 2020
Closed
@jelbourn
Copy link
Member Author

I believe this is obsolete with the new focus trap implementation.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) area: cdk/a11y feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jelbourn @crisbeto @josephperrott @mmalerba