-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(form-field): typography font-size is not used #8939
Comments
Possibly related to #5154 where the size was changed from 'inherit' to '16px' in the config, but then ignored in the theme |
This was discussed in some other issues together with @mmalerba. Using
|
@crisbeto makes sense, thanks - I had already done so! Is this something worth documenting somewhere? |
The current behavior (inheriting) is not obvious at all. I had set mat-typography with themes & was expecting my form inputs to remain consistent throughout the site irrespective of other elements used around. In my opinion, the typography font-size set at the root level is expected to remain consistent unless explicitly changed at the component level (like how the other typography settings like font-family behave). The current behavior, although deliberate, really feels like a bug. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
bug
What is the expected behavior?
The font-size of form-fields should be set by typography and default to 16px as per material spec
What is the current behavior?
The font-size for form fields is 'inherit'
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
5.0.0
Is there anything else we should know?
Looking through the code, I find no usage of the 'input' theme config in any of the form fields or controls that reference the font-size. I do see that the 'input' config is used for font-weight and line-height
The text was updated successfully, but these errors were encountered: