-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakpoints do not match the one in @angular/flex-layout #8928
Comments
@ThomasBurleson What are your thoughts for this? I interpretted it as the size begins at a breakpoint value, so the previous size would max out at |
@josephperrott - So I interpreted the breakpoint start as
If we consider the BreakPoint Diagram on Material Design, it does not clearly indicate which. Yet the authors do talk about amounts “under” a certain breakpoint; which implies the breakpoint includes the value. |
After speaking with the material design team, the breakpoints are inclusive of the start value as @ThomasBurleson noted. This however is only an issue in the variables we have defined in scss, but is not an issue within the preferred |
@josephperrott thanks for your effort. Thanks :) |
I am having the same problem in an application. The toolbar resizes its height based on the width. When the width is greater than 600px the height equals 64px otherwise 56px. With the breakpoints from angular-flex-layout you cannot make changes to the given layout. Of course you can make your own media-queries to make this work but it'd be really awesome if the breakpoints were aligned according to the specs. Anyway thanks for the great work! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Proposal, probably
What is the expected behavior?
The @angular/material2 README-file contains a link to @angular/flex-layout, so I expect, that the two libraries collaborate somehow and therefore share the same breakpoints.
What is the current behavior?
@angular/flex-layout
definesxs
asmax-width: 599px
(see Breakpoints), while@angular/material
defines it asmax-width: 600px
(see Variables).Same goes for
sm
(959px
vs960px
).What is the use-case or motivation for changing an existing behavior?
I would like to replace hardcoded
max-width
-statements in my code with scss-variables, however I am not sure, which breakpoints to use, since they differ (even if it's just 1px).The text was updated successfully, but these errors were encountered: