Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear stepper: already valid steps can be skipped without visit #8667

Closed
fpeterdev opened this issue Nov 27, 2017 · 5 comments · Fixed by #10048
Closed

Linear stepper: already valid steps can be skipped without visit #8667

fpeterdev opened this issue Nov 27, 2017 · 5 comments · Fixed by #10048
Assignees
Labels
G This is is related to a Google internal issue help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@fpeterdev
Copy link

Bug, feature request, or proposal:

Not sure but I think it's a bug

What is the expected behavior?

In case of linear stepper the user can skip a not completed step if the step is already valid.

What is the current behavior?

Already valid steps should be mandatory to complete as well.

What are the steps to reproduce?

The second step can be skipped here:
https://stackblitz.com/edit/angular-material2-issue-wnrjsf

What is the use-case or motivation for changing an existing behavior?

There are use-cases where we just want to show some information without any user input, or we can prefill data (e.g billing address), so it will be valid, but the user should check (and accept)

@fpeterdev fpeterdev changed the title Liner stepper: step without validation can be skipped Linear stepper: step without validation can be skipped Nov 27, 2017
@fpeterdev fpeterdev changed the title Linear stepper: step without validation can be skipped Linear stepper: already validation steps can be skipped without visit Nov 27, 2017
@fpeterdev fpeterdev changed the title Linear stepper: already validation steps can be skipped without visit Linear stepper: already valid steps can be skipped without visit Nov 27, 2017
@mmalerba mmalerba added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent help wanted The team would appreciate a PR from the community to address this issue labels Nov 28, 2017
@DmitryEfimenko
Copy link

I think I have run into the same issue.
For me, it needs to show that the step is completed disregarding whether the step is visited or not.
A quick change to the line 113 did the trick.
Before change:

return this.stepControl ? this.stepControl.valid && this.interacted : this.interacted;

After change:

return this.stepControl ? this.stepControl.valid : this.interacted;

@Goodwine
Copy link

@mmalerba

@mmalerba mmalerba added the G This is is related to a Google internal issue label Dec 12, 2017
@Goodwine
Copy link

Hello, has there been any progress on this bug?

@mmalerba
Copy link
Contributor

I see 2 possible solutions to this:

  1. Even if the step is valid, still require the user to go to the step and confirm that they want to move on without changing anything.
  2. Allow the user to skip the step if its valid, but update the icon to show the step as implicitly completed

I'm leaning toward solution 1 being the right solution. marking the stepper as linear should probably mean that the user does have to step through each step

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
G This is is related to a Google internal issue help wanted The team would appreciate a PR from the community to address this issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants