Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Add aria-labelledby to MatDialogConfig API #7755

Closed
opozo opened this issue Oct 13, 2017 · 3 comments
Closed

[Accessibility] Add aria-labelledby to MatDialogConfig API #7755

opozo opened this issue Oct 13, 2017 · 3 comments
Assignees
@crisbeto
Labels
good first issue This issue is a good place to start for first time contributors to the project help wanted The team would appreciate a PR from the community to address this issue P4 A relatively minor issue that is not relevant to core functions

Comments

@opozo
Copy link
Contributor

opozo commented Oct 13, 2017

Bug, feature request, or proposal:

Add aria-labelledby to MatDialogConfig API. MatDialogConfig API supports aria-describedby, but it doesn't support aria-labelledby.

Check MDN documentation for an example: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_dialog_role

What is the expected behavior?

Screen reader should read dialog label from aria-labelledby attribute.

What is the current behavior?

Screen reader is not reading dialog label.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

"@angular/material": "2.0.0-beta.12"
@jelbourn jelbourn assigned crisbeto and unassigned jelbourn Nov 15, 2017
@crisbeto crisbeto added the P5 The team acknowledges the request but does not plan to address it, it remains open for discussion label Nov 28, 2017
@jelbourn jelbourn added help wanted The team would appreciate a PR from the community to address this issue P4 A relatively minor issue that is not relevant to core functions good first issue This issue is a good place to start for first time contributors to the project and removed P5 The team acknowledges the request but does not plan to address it, it remains open for discussion has pr labels May 9, 2018
@glenngr
Copy link

glenngr commented Jun 10, 2018

Looks like this was fixed in #6558

@kwiniarski97
Copy link

@glenngr Aria labelledBy wasn't added to dialog config in that PR however I see than in newest angular version it is added.
See file: https://github.com/angular/components/blob/master/src/material/dialog/dialog-config.ts

@opozo opozo closed this as completed Aug 1, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
good first issue This issue is a good place to start for first time contributors to the project help wanted The team would appreciate a PR from the community to address this issue P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jelbourn @crisbeto @kwiniarski97 @glenngr @opozo