Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatDialog afterClosed before beforeClose with NoopAnimationsModule #7572

Closed
kxlow opened this issue Oct 6, 2017 · 4 comments
Closed

MatDialog afterClosed before beforeClose with NoopAnimationsModule #7572

kxlow opened this issue Oct 6, 2017 · 4 comments

Comments

@kxlow
Copy link

kxlow commented Oct 6, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

beforeClose should be called before afterClosed when a dialog closes, even with NoopAnimationsModule being used.

What is the current behavior?

afterClosed is called before beforeClose when NoopAnimationsModule is being used.
Does not happen if using BrowserAnimationsModule

What are the steps to reproduce?

https://stackblitz.com/edit/angular-material2-issue-ehetcr

What is the use-case or motivation for changing an existing behavior?

Incorrect behavior.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

master

@TomDemulierChevret
Copy link

TomDemulierChevret commented Oct 6, 2017

I strongly suspect it to be linked to #6736 & #6719
The pull request fixing it has been available for more than a month but still not been merged alas...

@billyjacobs2014
Copy link

What is the delay? I will potentially have to downgrade 6 separate projects after tediously upgrading them all, only to find out I can't open a dialog over dialog in IE.

@josephperrott
Copy link
Member

Closing as this is being addressed in #8051

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants