Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch UI for me-datepicker has no effect in mobile. #5834

Closed
JarekToro opened this issue Jul 18, 2017 · 3 comments · Fixed by #5943
Closed

Touch UI for me-datepicker has no effect in mobile. #5834

JarekToro opened this issue Jul 18, 2017 · 3 comments · Fixed by #5943
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@JarekToro
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

The date picker calendar should take up more screen real estate when touch ui mode is enabled.

What is the current behavior?

Touch ui mode works only in large displays, once you get to the size of a phone. It shrinks back to the regular date picker.

What are the steps to reproduce?

You can go on your phone (I have an iPhone7) go the example on https://material.angular.io/components/datepicker/overview. And look at the touch-ui example it doesn’t work. Just reverts back to the regular pop up.

No plunker needed as it’s displayed on the example page.

What is the use-case or motivation for changing an existing behavior?

To make it work :)

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

What I’ve used
2.0.0 beta8
Angular 4.3.0
iOS safari

@kara kara added the P2 The issue is important to a large percentage of users, with a workaround label Jul 18, 2017
@mmalerba mmalerba added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed P2 The issue is important to a large percentage of users, with a workaround labels Jul 21, 2017
@mmalerba
Copy link
Contributor

mmalerba commented Jul 21, 2017

The touch UI does appear to be working, it's just constrained to max of 80% of viewport width & height, which doesn't come out to much bigger than the popup. I can create a PR to bump it a little higher, maybe 90%, 100% wouldn't look good since the calendar would be touching the edge of the viewport.

Edit: actually looks like in portrait mode it only uses 64% of the width, will fix so it uses 80% as originally intended.

@JarekToro
Copy link
Author

Perfect!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants