-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'beforeClose' Observable to MdDialogRef #5209
Comments
Related to #3460 |
Yeah, having |
Oh also #4647 |
Ah, tracking via #4647 (thanks @willshowell) |
The onBefore/closeAttempt/etc seems more concerned with how the user attempts to close the dialog, and the possibility of canceling that. |
@wulfsberg You're right that #3460 is really just focused on how the dialog has been closed. I'd suggest mentioning in #4647 that a beforeClose observable should emit the closing value so that your use case doesn't accidentally get forgotten here |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Feature request
What is the expected behavior?
Being able to start processing instantly when a user selects an option in an MdDialog.
What is the current behavior?
An 'afterClose' Observable is available which only fires after all animations are done.
What are the steps to reproduce?
The behavior is easily seen on the "Examples" page of https://material.angular.io/components/component/dialog
What is the use-case or motivation for changing an existing behavior?
In many cases, a dialog functions as a confirmation for some additional processing (such as deleting an item), which in turn asynchronously updates the interface (say, removing the item from a list once deleted serverside).
Having to wait for an animation to finish before launching the async server call introduces unnecessary latency in the UI.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Material 2.0.0-beta.6
Is there anything else we should know?
Delaying until after animation is a deliberate choice, as described here: #3890, but I find that reacting instantly is also a reasonable behavior, so I propose an Observable for each.
The text was updated successfully, but these errors were encountered: