Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain existing ripples when button state changes to disabled #4364

Closed
willshowell opened this issue May 2, 2017 · 3 comments · Fixed by #4372
Closed

Retain existing ripples when button state changes to disabled #4364

willshowell opened this issue May 2, 2017 · 3 comments · Fixed by #4372
Assignees

Comments

@willshowell
Copy link
Contributor

Bug, feature request, or proposal:

Bug

Expected behavior

When clicking on a button that will immediately become disabled, the ripple should remain until it fades out.

after

Current behavior

The ripple is immediately destroyed when the button state changes to disabled.

before

What are the steps to reproduce?

http://plnkr.co/edit/otcf7ejUS9GTY1s3s3v2?p=preview

Is there anything else we should know?

Happy to open a PR if this is desired behavior

@devversion
Copy link
Member

devversion commented May 2, 2017

Yep. We should remove the *ngIf and just use the mdRippleDisabled binding.

Let me know if you want to put a PR together. Otherwise I can take care of it :)

@willshowell
Copy link
Contributor Author

@devversion up at #4372!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants