Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-dialog should block page scroll #3908

Closed
improvise opened this issue Apr 5, 2017 · 3 comments
Closed

md-dialog should block page scroll #3908

improvise opened this issue Apr 5, 2017 · 3 comments

Comments

@improvise
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

When a dialog is open, the page should not scroll. Only the dialog should be scrollable.

What is the current behavior?

When a dialog is open, the user can still scroll the page.

What are the steps to reproduce?

https://plnkr.co/edit/70UnwmTG2mvLWkhOSU4a?p=preview

What is the use-case or motivation for changing an existing behavior?

When a dialog is open, a scrollable page in the background is confusing for the user.

In Angular Material 1, this is configurable with disableParentScroll https://material.angularjs.org/latest/api/service/$mdDialog . While that would be nice to have, disabling the behavior would work as well.

Which versions of Angular, Material, OS, browsers are affected?

I haven't tested extensively, but this affects at least the latest version of Angular / Material / Chrome that we're using.

@fxck
Copy link
Contributor

fxck commented Apr 5, 2017

dupe of about 10 other issues.. also #1971

@jelbourn
Copy link
Member

Now tracking via #4093

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants