Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a core.umd.js bundle to published package #3534

Closed
mikehaas763 opened this issue Mar 9, 2017 · 7 comments
Closed

Add a core.umd.js bundle to published package #3534

mikehaas763 opened this issue Mar 9, 2017 · 7 comments

Comments

@mikehaas763
Copy link

I'm willing to put the PR together for this. I would like to rely on Overlay and Portal. So it'd be nice to import just a material core.umd.js and avoid the other Material components.

Will the PR be considered/accepted if I take time putting it together?

@devversion
Copy link
Member

devversion commented Mar 9, 2017

@jelbourn If we do this, then I would highly recommend after PR #3443. Otherwise there will be X rebases.

Also I think if you just want to use the CoreModule, you can just use the module and use treeshaking to get rid of the other components.

@mikehaas763
Copy link
Author

That's fine I'll keep rebasing off your branch until it gets merged!

@mikehaas763
Copy link
Author

@devversion meaning point my app's build to CoreModule and compile that?

@devversion
Copy link
Member

@mikehaas763 Yeah just using MdCoreModule instead of MaterialModule would do it.

Make sure you have a bundler, like Webpack 2, that automatically removes the unused chunk of code.

@mikehaas763
Copy link
Author

mikehaas763 commented Mar 9, 2017

Yeah and I've done that before but it always had weird issues when pointing my apps build at something in node_modules. You gotta pretty much set up a completely separate config that ignores any linting etc. would just be nice to consumers to have a core bundle already built

@devversion
Copy link
Member

The package structure has changed. Currently we only ship a bundle of the full Material library.

We have plans on shipping the different components bundled as well. This would then include a core.js bundle.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants