Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom class on select overlay #3292

Closed
robianmcd opened this issue Feb 24, 2017 · 3 comments
Closed

Custom class on select overlay #3292

robianmcd opened this issue Feb 24, 2017 · 3 comments

Comments

@robianmcd
Copy link

Bug, feature request, or proposal:

feature request

What is the desired behavior?

There would be a way to specity a custom class on the overlay for a select element. e.g.

<md-select overlayClass="my-theme-1"></md-select>

What is the current behavior?

No way to add a custom class to the overlay for a select

What is the use-case or motivation for changing an existing behavior?

I'm using multiple themes in the way described in the guide .e.g.

@include angular-material-theme($defaultTheme);

.my-theme-1 {
  @include angular-material-theme($myTheme1);
}

.my-theme-2 {
  @include angular-material-theme($myTheme2);
}

So if I have a select inside an element with class="my-theme-1" I would want the select to get the styles form $myTheme1.

<div class="my-theme-1">
  <md-select></md-select>
</div>

This doesn't work for the select's overlay as the overlay is appended to the body.

Which versions of Angular, Material, OS, browsers are affected?

Material: beta-2

@kara
Copy link
Contributor

kara commented Feb 24, 2017

This looks like a dupe of #2662. We have a PR waiting to merge here that will allow easy adding of themes to overlay-based components, so should get in soon.

@kara kara closed this as completed Feb 24, 2017
@robianmcd
Copy link
Author

@kara great thanks! I'll keep an eye on that PR

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants