Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests process crashes #3074

Closed
dahaupt opened this issue Feb 12, 2017 · 14 comments · Fixed by #3080
Closed

Unit tests process crashes #3074

dahaupt opened this issue Feb 12, 2017 · 14 comments · Fixed by #3080
Assignees
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@dahaupt
Copy link

dahaupt commented Feb 12, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

The unit tests should work on master branch.

What is the current behavior?

The process fails in step :build:components:spec with:

node_modules/@types/jasmine/index.d.ts(39,38): error TS2371: A parameter initializer is only allowed in a function or constructor implementation.
node_modules/@types/jasmine/index.d.ts(39,46): error TS2304: Cannot find name 'keyof'.
node_modules/@types/jasmine/index.d.ts(39,52): error TS1005: '=' expected.

What are the steps to reproduce?

Run gulp test on the master branch.

Which versions of Angular, Material, OS, browsers are affected?

Latest Version of Material, Windows 10, Angular 2.4.7

Is there anything else we should know?

I'm no expert in unit tests, but simply starting them on a new cloned repository should work (e2e tests are working fine). It could be possible too, that this is just a problem on my system, because otherwise someone would have already noticed this.

@modernfidelity
Copy link

I'll also getting this via -> gulp build:release at the "Starting ':build:components:ngc'" step

@kara
Copy link
Contributor

kara commented Feb 13, 2017

Running tests works for me on master. What version of node are you running? I'm running 6.2.2.

@kara kara added the cannot reproduce The team is unable to reproduce this issue with the information provided label Feb 13, 2017
@dahaupt
Copy link
Author

dahaupt commented Feb 13, 2017

@kara I'm running version v6.9.5 of node (latest).

@trshafer
Copy link
Contributor

I have the same issue. I'm running 6.9.4, as that is what travis is running on: https://github.com/angular/material2/blob/master/.travis.yml#L5

@kara
Copy link
Contributor

kara commented Feb 13, 2017

How about Typescript versions? I'm doing a fresh npm install now from scratch to see if that breaks anything..

@dahaupt
Copy link
Author

dahaupt commented Feb 13, 2017

My global Typescript version is 2.1.5, in the project (master) it is 2.0.10. I'm not sure which one is used for tests.

@trshafer
Copy link
Contributor

Did a git bisect of "npm install && npm test". This is the commit where it changed from a warning to an error 4a4261e.

@kara kara removed the cannot reproduce The team is unable to reproduce this issue with the information provided label Feb 13, 2017
@kara
Copy link
Contributor

kara commented Feb 13, 2017

Okay, just blew away my node modules and started from scratch. Also getting the error now.

@kara kara added the P2 The issue is important to a large percentage of users, with a workaround label Feb 13, 2017
@modernfidelity
Copy link

modernfidelity commented Feb 13, 2017 via email

@owlstack
Copy link

I'm having the same issue. Is this resolved? should I wait for latest release?

@trshafer
Copy link
Contributor

@owlstack, are you still getting the issue with #3080 merged in? Did you remove your node_modules folder and re install?

@Slashmsu
Copy link

I have the same error, I removed node_modules and reinstalled it, but I still have this error

@jppellerin
Copy link

I had this issue and I can confirm that going back down to 2.5.38 resolved it.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants