Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(theme): schematic doesn't ask for error hex color #29969

Open
1 task
AnkitaSood opened this issue Nov 5, 2024 · 2 comments
Open
1 task

bug(theme): schematic doesn't ask for error hex color #29969

AnkitaSood opened this issue Nov 5, 2024 · 2 comments
Labels
area: cdk/schematics cdk/schematics is *not* a public API area: theming P4 A relatively minor issue that is not relevant to core functions

Comments

@AnkitaSood
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

As of v18.2, a theme can be generated with a custom color with the following schematic:
ng generate @angular/material:m3-theme

The schematic then prompts for hex codes for primary, secondary, tertiary, neutral colors.

It auto generates an error code palette based on the primary hex provided. It doesn't prompt the user to enter their own error color.

Reproduction

StackBlitz link:
Steps to reproduce:

  1. Ensure app and material are on latest stable version - v18.2
  2. Run the schematic ng generate @angular/material:m3-theme to generate a custom theme.
  3. Notice that the schematic doesn't prompt to enter hex color to be used to represent the error color palette.

Expected Behavior

The schematic should prompt user to enter hex code that is used to represent the error color palette.

Actual Behavior

Schematic doesn't prompt to enter hex color to be used to represent the error color palette.

Environment

  • Angular: 18.2
  • CDK/Material: 18.2
  • Browser(s):
  • Operating System (e.g. Windows, macOS, Ubuntu):
@AnkitaSood AnkitaSood added the needs triage This issue needs to be triaged by the team label Nov 5, 2024
@wagnermaciel wagnermaciel added P4 A relatively minor issue that is not relevant to core functions area: cdk/schematics cdk/schematics is *not* a public API area: theming and removed needs triage This issue needs to be triaged by the team labels Nov 7, 2024
@wagnermaciel
Copy link
Contributor

@mmalerba Is this working as intended?

@isochronous
Copy link

It also does not offer the crucial "exact color match" option that the actual theme generation utility includes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cdk/schematics cdk/schematics is *not* a public API area: theming P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

No branches or pull requests

3 participants