Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(card): align card appearance with m3 specs #29840

Open
1 task
MikaStark opened this issue Oct 7, 2024 · 0 comments · May be fixed by #29868
Open
1 task

bug(card): align card appearance with m3 specs #29840

MikaStark opened this issue Oct 7, 2024 · 0 comments · May be fixed by #29868
Labels
area: material/card P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@MikaStark
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

Hi Angular Material Team !
Thanks for all your hard work on this project.
Today I want to pointout the Material 3 specification for cards mention 3 differents appearance :

That's why I proposed to add a new filled appearance to the existing ones and rename raised into elevated.

I understand this is a very small and easy-to-workaround issue but it would be nice to have a better alignement with Material 3 specs and prevent developers to add extra (yet tiny) style code to get the expected appearance.

Reproduction

StackBlitz link: https://stackblitz.com/edit/zkkqyi?file=src%2Fexample%2Fcard-footer-example.css

Expected Behavior

Having 3 appearance for cards : outlined, elevated and filled

Actual Behavior

  • Missing filled appearance
  • elevated appearance is instead named raised

Environment

  • Angular: 18.2.7
  • CDK/Material: 18.2.7
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Ubuntu 24.04
@MikaStark MikaStark added the needs triage This issue needs to be triaged by the team label Oct 7, 2024
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: material/card and removed needs triage This issue needs to be triaged by the team labels Oct 9, 2024
naaajii added a commit to naaajii/components that referenced this issue Oct 12, 2024
@naaajii
feat(material/card): support filled variant
07225d2 
this commit add `filled` variant for material card which provides subtle seperation from background and has less emphasis than elevated or outlined cards

fixes angular#29840
@naaajii naaajii linked a pull request Oct 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: material/card P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(material/card): support filled variant naaajii/components
2 participants
@crisbeto @MikaStark