Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs-feat(tabs): Include example/mention of setting mat-align-tabs dynamically #29029

Open
tkutcher opened this issue May 9, 2024 · 0 comments · May be fixed by #29798
Open

docs-feat(tabs): Include example/mention of setting mat-align-tabs dynamically #29029

tkutcher opened this issue May 9, 2024 · 0 comments · May be fixed by #29798
Labels
area: material/tabs docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions

Comments

@tkutcher
Copy link

tkutcher commented May 9, 2024

Documentation Feedback

Since mat-align-tabs is not aliased as a property/input binding (like how mat-stretch-tabs is), and it is not in the ts "API", I wound up getting myself hung up for a bit when I tried to set this dynamically as a property binding (before I realized it was an attribute) with confusing compilation errors. Mostly my oversight, but it gets confusing when the line between attribute & property is blurry for these sorts of "configurations" of the components. Perhaps it may just be a good spot to mention/link to https://angular.io/guide/attribute-binding.

In general, it might be nice if attributes like this (that only interface to scss/style implementation) could still be "standardized", or at least mentioned, in the "API" section of the docs vs. relying solely on examples / scss source.

Ultimately I figured it out without too much headache - but just a suggestion. Thanks!

Affected documentation page

https://material.angular.io/components/tabs/overview

@tkutcher tkutcher added docs This issue is related to documentation needs triage This issue needs to be triaged by the team labels May 9, 2024
@amysorto amysorto added P4 A relatively minor issue that is not relevant to core functions area: material/tabs and removed needs triage This issue needs to be triaged by the team labels May 10, 2024
naaajii added a commit to naaajii/components that referenced this issue Sep 27, 2024
adds an example for dynamically aligned tabs group

closes angular#29029
naaajii added a commit to naaajii/components that referenced this issue Oct 1, 2024
adds an example for dynamically aligned tabs group

closes angular#29029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: material/tabs docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants