Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdDialogModule does not work with dynamic theming #2536

Closed
melocotton opened this issue Jan 5, 2017 · 4 comments
Closed

MdDialogModule does not work with dynamic theming #2536

melocotton opened this issue Jan 5, 2017 · 4 comments
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@melocotton
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

MdDialogModule should also receive css styles when dynamically switching from one css (or scss) to another to apply different themes : our themes are applied to the node, but MdDialogModule is added outside this node (and generated dynamically by javascript at runtime which means its own node is not visible in DOM before actually been displayed when the MdDialogModule is called), thus does not receive the theme.

What is the current behavior?

MdDialogModule does not receive the styles when dynamically switched by user

What are the steps to reproduce?

  • Go to your demo website at : https://material2-app.firebaseapp.com/
  • switch to dark theme
  • click on the "Dialog" button at the bottom of the page
    -> The dialog does not receive the dark theme

What is the use-case or motivation for changing an existing behavior?

Existing behavior is incorrect

Which versions of Angular, Material, OS, browsers are affected?

angular 2.4.1
material 2.0.0-beta.1

Is there anything else we should know?

You are lucky guys, because my collegue might have found a workaround to this issue (using renderer.setElementClass() to inject our theme class in the MdDialogModule), but please fix this ASAP (and also add resources to create the datepicker everyone needs as well).

@melocotton
Copy link
Author

Any news on this ?

@EladBezalel EladBezalel added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jan 12, 2017
@draiche
Copy link

draiche commented Jan 18, 2017

@melocotton Did your workaround end up helping get around this? I'm encountering the same issue. If it worked would you be able to share your solution?

Thanks, and I also would appreciate this being changed.

@crisbeto
Copy link
Member

crisbeto commented Feb 3, 2017

This is being worked on. I'll close this issue since it's already tracked via #2662.

@crisbeto crisbeto closed this as completed Feb 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

4 participants