Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(mat-dialog): Tab content jumps a little right after dialog opening. #22323

Closed
liesahead opened this issue Mar 24, 2021 · 6 comments
Closed
Labels
area: material/dialog area: material/tabs needs: discussion Further discussion with the team is needed before proceeding

Comments

@liesahead
Copy link

liesahead commented Mar 24, 2021

Reproduction

jumping_dialog_reproduction

Here are the two adjacent frames extracted from the gif above, there you can see that alignment of elements is slightly different (if you don't see - I recommend to use page ruler to make sure I don't lie).
frame_1 1frame_2 2

Use StackBlitz to reproduce your issue:

Steps to reproduce:

  1. Open the given link and open/close dialog at least a few times.
  2. If cannot reproduce the bug - enable max cpu throttling in devtools.

Option 2:

  1. Open the angular material documentation: https://material.angular.io/components/dialog/overview
  2. Open/close first dialog at least a few times.
  3. If cannot reproduce the bug - enable max cpu throttling in devtools.

Expected Behavior

Dialog content shouldn't move after dialog opens with that beautiful 'grow' style animation.

Actual Behavior

The dialog content is jumping a little (depends on what content it has). I'm afraid that the issue #13870 also might be related to this bug. So it's the dialog's fault that expansion panel is expanded and content is jumping.

Environment

  • Browser(s): Chrome (Version 89.0.4389.90 (Official Build) (64-bit))
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows 10 latest version
@liesahead liesahead added the needs triage This issue needs to be triaged by the team label Mar 24, 2021
@crisbeto
Copy link
Member

crisbeto commented Mar 29, 2021

I don't see any jumping on my end. Are you referring to the blurriness between the first and second screenshot?

@crisbeto crisbeto added area: material/dialog area: material/tabs needs: clarification The issue does not contain enough information for the team to determine if it is a real bug and removed needs triage This issue needs to be triaged by the team labels Mar 29, 2021
@liesahead
Copy link
Author

liesahead commented Mar 30, 2021

@crisbeto, Hi, thanks for checking! Not really, blurriness is an animation which is perfectly fine. In gif above you should focus on watching the text inputs (how they jump a little up after dialog init). Looks like it's just around 1 or 2px, but when almost all elements move it's noticeable (at least for me). Here are two adjacent frames and I used ruler to try to show that inputs are slightly in different positions.

image

@crisbeto
Copy link
Member

crisbeto commented Apr 4, 2021

Thanks for the screenshot, but I still can't notice it on my machine. It looks like some kind of artifact from the animation so I'm not sure whether we can do much about it.

@crisbeto crisbeto added needs: discussion Further discussion with the team is needed before proceeding and removed needs: clarification The issue does not contain enough information for the team to determine if it is a real bug labels Apr 4, 2021
@liesahead
Copy link
Author

liesahead commented Apr 4, 2021

It was noticeable on my old laptop which is super slow (dual core CPU). Now I'm using high-end laptop and can't notice any jumping without enabling hard CPU throttling. So, I'm not sure, if nobody except me experienced such issue, probably this ticket should be closed. What do you think?

@jelbourn
Copy link
Member

Closing since it seems to not be an issue any more

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/dialog area: material/tabs needs: discussion Further discussion with the team is needed before proceeding
Projects
None yet
Development

No branches or pull requests

3 participants