docs(material/button-toggle): add missing type on public API #22224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an explicit type to `MatButtonToggleGroup` so that it can show up in the docs. This change is merge safe, because the type is the same as the inferred type that was in place already. Fixes angular#22026.
crisbeto
added
merge safe
P4
google-cla
bot
added
the
cla: yes
| @@ -83,7 +83,8 @@ export const MAT_BUTTON_TOGGLE_GROUP_VALUE_ACCESSOR: any = { | |||
| multi: true | |||
| }; | |||
|
|
|||
| let _uniqueIdCounter = 0; | |||
| // Counter used to generate unique IDs. | |||
| let uniqueIdCounter = 0; | |||
There was a problem hiding this comment.
Just for clarification, could you fill me in on why we are making this public? Or is there another reason we're removing the underscore?
There was a problem hiding this comment.
I didn't make it public, I just removed the underscore since the constant isn't being exported so the name doesn't really matter.
This was referenced Mar 17, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an explicit type to
MatButtonToggleGroupso that it can show up in the docs. This change is merge safe, because the type is the same as the inferred type that was in place already.Fixes #22026.