Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): hide date selection model from docs #22056

Merged
merged 1 commit into from
Mar 2, 2021
Merged

fix(material/datepicker): hide date selection model from docs #22056

merged 1 commit into from
Mar 2, 2021

Conversation

crisbeto
Copy link
Member

  • Hides some symbols related to the date selection model from the public API docs.
  • Fixes that MatDateSelectionModel was marked as a directive, rather than an injectable.

Fixes #21985.

@crisbeto
fix(material/datepicker): hide date selection model from docs
43b41b0 
* Hides some symbols related to the date selection model from the public API docs.
* Fixes that `MatDateSelectionModel` was marked as a directive, rather than an injectable.

Fixes angular#21985.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Feb 28, 2021
@crisbeto crisbeto requested a review from mmalerba as a code owner February 28, 2021 10:53
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 28, 2021
mmalerba
mmalerba approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 1, 2021
@wagnermaciel wagnermaciel merged commit 8497bb1 into angular:master Mar 2, 2021
wagnermaciel pushed a commit that referenced this pull request Mar 2, 2021
@crisbeto @wagnermaciel
fix(material/datepicker): hide date selection model from docs (#22056)
92de837 
* Hides some symbols related to the date selection model from the public API docs.
* Fixes that `MatDateSelectionModel` was marked as a directive, rather than an injectable.

Fixes #21985.

(cherry picked from commit 8497bb1)
This was referenced Mar 6, 2021
Closed
Closed
Merged
Merged
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatRangeDateSelectionModel should be excluded from public API
3 participants
@crisbeto @mmalerba @wagnermaciel