Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-progress-bar): run resize observer outside zone #21564

Merged
merged 1 commit into from
Mar 5, 2021
Merged

fix(material-experimental/mdc-progress-bar): run resize observer outside zone #21564

merged 1 commit into from
Mar 5, 2021

Conversation

crisbeto
Copy link
Member

Runs the ResizeObserver from the progress bar outside of the NgZone so that it doesn't trigger change detection.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Jan 12, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 12, 2021
@crisbeto crisbeto force-pushed the progress-bar-resize-observer branch from d011c7c to d028768 Compare January 21, 2021 19:58
wagnermaciel
wagnermaciel approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 26, 2021
@crisbeto
fix(material-experimental/mdc-progress-bar): run resize observer outs…
ea87e65 
…ide zone

Runs the `ResizeObserver` from the progress bar outside of the `NgZone` so that it doesn't
trigger change detection.
@crisbeto crisbeto force-pushed the progress-bar-resize-observer branch from d028768 to ea87e65 Compare February 26, 2021 20:39
@annieyw annieyw merged commit bd2c324 into angular:master Mar 5, 2021
annieyw pushed a commit that referenced this pull request Mar 5, 2021
@crisbeto @annieyw
fix(material-experimental/mdc-progress-bar): run resize observer outs…
e94b7bd 
…ide zone (#21564)

Runs the `ResizeObserver` from the progress bar outside of the `NgZone` so that it doesn't
trigger change detection.

(cherry picked from commit bd2c324)
This was referenced Mar 11, 2021
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
This was referenced Mar 18, 2021
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@wagnermaciel wagnermaciel

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @wagnermaciel @annieyw