Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable ripples globally #1776

Closed
mwarton opened this issue Nov 8, 2016 · 5 comments
Closed

Add option to disable ripples globally #1776

mwarton opened this issue Nov 8, 2016 · 5 comments
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue

Comments

@mwarton
Copy link

mwarton commented Nov 8, 2016

Bug, feature request, or proposal:

An option to globally disable ripple animations would help to reduce flakiness in screendiff testing.

What is the expected behavior?

Globally diable ripple animations for screen diff testing.

What is the current behavior?

Ripple animations can only be disabled on an element by element basis.

What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?

Making screenshot diff tests more reliable.

Which versions of Angular, Material, OS, browsers are affected?

angular/material2

Is there anything else we should know?

@jelbourn jelbourn added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Nov 8, 2016
@jelbourn
Copy link
Member

jelbourn commented Nov 8, 2016

This should probably be similar to disabling animations globally.

@spock123
Copy link

It would be a nice option to have.

Especially on mobile devices, the ripples animations kill anything but the top dog phones.

@jelbourn jelbourn added the help wanted The team would appreciate a PR from the community to address this issue label Nov 11, 2016
@M-a-c
Copy link
Contributor

M-a-c commented Mar 24, 2017

@jelbourn
Copy link
Member

So it is.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue
Projects
None yet
Development

No branches or pull requests

5 participants