Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK Overlay not calling the detach event while using CloseScrollStrategy #16779

Closed
aryaroudi opened this issue Aug 14, 2019 · 4 comments · Fixed by #7950
Closed

CDK Overlay not calling the detach event while using CloseScrollStrategy #16779

aryaroudi opened this issue Aug 14, 2019 · 4 comments · Fixed by #7950
Labels
area: cdk/overlay P2 The issue is important to a large percentage of users, with a workaround

Comments

@aryaroudi
Copy link

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/edit/angular-jfzhcl

Steps to reproduce:

  1. Open the menu do the scroll, menu get closed and now you need to click 2 times on the button to open the menu again

Expected Behavior

What behavior were you expecting to see?

the detach output should be called to close the menu correctly.

Actual Behavior

What behavior did you actually see?

The detach output never call the close function that I sent in when the menu gets closed by doing the scroll

Environment

  • Angular: 8
  • CDK/Material: 8
  • Browser(s): chrome
  • Operating System (e.g. Windows, macOS, Ubuntu):
@crisbeto
Copy link
Member

Should be fixed by #7950.

@andrewseguin andrewseguin added the P2 The issue is important to a large percentage of users, with a workaround label Aug 19, 2019
@aryaroudi
Copy link
Author

thanks @crisbeto waiting for the merge 👍

@vanrado
Copy link

vanrado commented Jul 1, 2020

Thanks for initiative to fix that, but it seems that fix is still not merged. Is there any easy workaround? I would use close scroll strategy. One workaround could be create custom listener/observer on scrollevent, but I prefer to use more "Angular way"... Thanks

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: cdk/overlay P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants