Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve focus-trapping robustness #1625

Closed
jelbourn opened this issue Oct 27, 2016 · 2 comments
Closed

Improve focus-trapping robustness #1625

jelbourn opened this issue Oct 27, 2016 · 2 comments
Labels
Accessibility This issue is related to accessibility (a11y) feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions

Comments

@jelbourn
Copy link
Member

jelbourn commented Oct 27, 2016

The current <focus-trap> directive uses a very simple (naive) approach to focus trapping.

  • It assumes that the tab order is the same as DOM order, which is not necessarily true.
  • Things like tabIndex > 0, flex order, and shadow roots can cause to two to misalign.

This behavior needs to be improved, using ally.js as a guide.

This is somewhat complicated by the need to detect different browsers / platforms, for which behavior varies subtly.

@jelbourn jelbourn added feature This issue represents a new feature or feature request rather than a bug or bug fix Accessibility This issue is related to accessibility (a11y) labels Oct 27, 2016
@jelbourn jelbourn added the P4 A relatively minor issue that is not relevant to core functions label Jun 6, 2017
@jelbourn
Copy link
Member Author

jelbourn commented Jun 6, 2017

The work I had in mind for this issue is done

@jelbourn jelbourn closed this as completed Jun 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

No branches or pull requests

1 participant