Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append placeholder required asterix to Validators.required #10261

Closed
tomgruszowski opened this issue Mar 4, 2018 · 2 comments
Closed

Append placeholder required asterix to Validators.required #10261

tomgruszowski opened this issue Mar 4, 2018 · 2 comments

Comments

@tomgruszowski
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Input label/placeholder asterix (*) is appended based on FormControl - Validators.required and not just the HTML 'required' element attribute. The code should check the required attribute and the FormControl Validators for auto inserting the asterix.

What is the current behavior?

Required asterix only works with the input required attribute.

What is the use-case or motivation for changing an existing behavior?

Reactive forms moves the validation complexity away from markup and onto the code; this forces the markup and code to have the same duplicate required validation.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Latest ng/mat 5.x

@crisbeto
Copy link
Member

crisbeto commented Mar 5, 2018

Closing as a duplicate of #2574.

@crisbeto crisbeto closed this as completed Mar 5, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants