From 23158d80369051ab2760fffbb519119b6a26f06d Mon Sep 17 00:00:00 2001 From: crisbeto Date: Sat, 16 Mar 2019 18:11:53 +0100 Subject: [PATCH] fix(slide-toggle): clear name from host node Along the same lines as #15422 and #15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`. --- src/material/slide-toggle/slide-toggle.spec.ts | 6 ++++++ src/material/slide-toggle/slide-toggle.ts | 1 + 2 files changed, 7 insertions(+) diff --git a/src/material/slide-toggle/slide-toggle.spec.ts b/src/material/slide-toggle/slide-toggle.spec.ts index ed97ce8ab4ec..84bdf6ce4049 100644 --- a/src/material/slide-toggle/slide-toggle.spec.ts +++ b/src/material/slide-toggle/slide-toggle.spec.ts @@ -805,6 +805,12 @@ describe('MatSlideToggle with forms', () => { expect(slideToggleEl.classList).toContain('ng-invalid'); expect(slideToggleEl.classList).not.toContain('ng-valid'); }); + + it('should clear static name attribute from the slide toggle host node', () => { + const hostNode = fixture.nativeElement.querySelector('.mat-slide-toggle'); + expect(inputElement.getAttribute('name')).toBeTruthy(); + expect(hostNode.hasAttribute('name')).toBe(false); + }); }); describe('with model and change event', () => { diff --git a/src/material/slide-toggle/slide-toggle.ts b/src/material/slide-toggle/slide-toggle.ts index 9dd5a2f9e971..039981e7c217 100644 --- a/src/material/slide-toggle/slide-toggle.ts +++ b/src/material/slide-toggle/slide-toggle.ts @@ -87,6 +87,7 @@ const _MatSlideToggleMixinBase: '[attr.tabindex]': 'disabled ? null : -1', '[attr.aria-label]': 'null', '[attr.aria-labelledby]': 'null', + '[attr.name]': 'null', '[class.mat-checked]': 'checked', '[class.mat-disabled]': 'disabled', '[class.mat-slide-toggle-label-before]': 'labelPosition == "before"',