Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

remove 'replace' property from tabs directive example on home page #159

Open
MokoJumbie opened this issue Feb 4, 2015 · 2 comments
Open

Comments

@MokoJumbie
Copy link

Considering that 'replace' is deprecated, should the use of it still be encouraged by one of the first directive code examples newcomers will see on the site?

@MokoJumbie MokoJumbie changed the title remove 'replace' attribute from tabs example on home page remove 'replace' property from tabs directive example on home page Feb 4, 2015
@JordanMajd
Copy link

I've been looking into this but I'm not so sure this is an issue. Even though it is currently deprecated it will not be removed until v2.0 according to the current docs. In addition, @caitp mentioned in angular/angular.js@eec6394 that

replace: true isn't being removed. You can be pretty certain of that, like as cute as it is for us to say it's deprecated, it's not going anywhere.

On the other hand, if this is something that needs resolved I would be interested in looking in to it.

@gkalpak
Copy link
Member

gkalpak commented Sep 5, 2015

While it's not going anywhere in the foreseeable future, it would be nice (imo) to not promote it (by featuring it on examples).

If anyone is up for a PR, we could consider removing it (I guess).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants