WIP: initial version of ng_package #21431

IgorMinar · 2018-01-10T00:53:18Z

No description provided.

mary-poppins · 2018-01-10T00:58:59Z

You can preview 4cec674 at https://pr21431-4cec674.ngbuilds.io/.

mary-poppins · 2018-01-10T02:28:42Z

You can preview 774d202 at https://pr21431-774d202.ngbuilds.io/.

mary-poppins · 2018-01-10T02:28:51Z

You can preview e6e595a at https://pr21431-e6e595a.ngbuilds.io/.

mary-poppins · 2018-01-10T03:00:25Z

You can preview ea7ede6 at https://pr21431-ea7ede6.ngbuilds.io/.

IgorMinar · 2018-01-10T08:42:48Z

@alexeagle I pulled your branch, yarn installed and bazel build and then get this error because I yarn installed in the aio/ dir and not in the root:

$ bazel build //packages/core:package
INFO: Analysed target //packages/core:package (0 packages loaded).
INFO: Found 1 target...
ERROR: /private/var/tmp/_bazel_iminar/9b8801a4939e9750a817dc0cb35bbbca/external/angular/src/packager/BUILD.bazel:4:1: Compiling TypeScript (devmode) @angular//src/packager:lib failed (Exit 1)
external/angular/src/packager/index.ts(1,22): error TS7016: Could not find a declaration file for module 'shelljs'. '/private/var/tmp/_bazel_iminar/9b8801a4939e9750a817dc0cb35bbbca/execroot/angular_src/node_modules/shelljs/shell.js' implicitly has an 'any' type.
external/angular/src/packager/index.ts(16,12): error TS7006: Parameter 'f' implicitly has an 'any' type.
external/angular/src/packager/index.ts(23,41): error TS7006: Parameter 'f' implicitly has an 'any' type.

Target //packages/core:package failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 3.259s, Critical Path: 2.59s
FAILED: Build did NOT complete successfully

This sounds like a trap, especially for those that manage yarn dependencies and switch branches. Could we have bazel run yarn install or verify automatically?

alexeagle · 2018-01-10T23:48:32Z

Yes, that's bazel-contrib/rules_nodejs#1 I can explain and/or find a link to why bazel doesn't install dependencies into your project.

…

On Wed, Jan 10, 2018 at 12:43 AM Igor Minar ***@***.***> wrote: @alexeagle <https://github.com/alexeagle> I pulled your branch, yarn installed and bazel build and then get this error because I yarn installed in the aio/ dir and not in the root: $ bazel build //packages/core:package INFO: Analysed target //packages/core:package (0 packages loaded). INFO: Found 1 target... ERROR: /private/var/tmp/_bazel_iminar/9b8801a4939e9750a817dc0cb35bbbca/external/angular/src/packager/BUILD.bazel:4:1: Compiling TypeScript (devmode) @angular//src/packager:lib failed (Exit 1) external/angular/src/packager/index.ts(1,22): error TS7016: Could not find a declaration file for module 'shelljs'. '/private/var/tmp/_bazel_iminar/9b8801a4939e9750a817dc0cb35bbbca/execroot/angular_src/node_modules/shelljs/shell.js' implicitly has an 'any' type. external/angular/src/packager/index.ts(16,12): error TS7006: Parameter 'f' implicitly has an 'any' type. external/angular/src/packager/index.ts(23,41): error TS7006: Parameter 'f' implicitly has an 'any' type. Target //packages/core:package failed to build Use --verbose_failures to see the command lines of failed build steps. INFO: Elapsed time: 3.259s, Critical Path: 2.59s FAILED: Build did NOT complete successfully This sounds like a trap, especially for those that manage yarn dependencies and switch branches. Could we have bazel run yarn install or verify automatically? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21431 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC5Iz2vhAZIbSmpnRzesT3-tGzDXUtiks5tJHg5gaJpZM4RYqGR> .

ngbot · 2018-01-12T02:09:36Z

I see that you just added the PR action: merge label. It won't do anything good though, because the following checks are still failing:

conflicts with base branch "master"
missing required label: "PR target:"
statuses failing/pending (ci/circleci: lint, continuous-integration/travis-ci/pr, code-review/pullapprove)

If you want your PR to be merged, it has to pass all the checks. But if you have a good reason to want to merge this, please contact the caretaker to let them know.

IgorMinar · 2018-01-13T02:10:30Z

packages/bazel/src/ng_package.bzl

+      inputs = collect_es6_sources(ctx).to_list(),
+      executable = ctx.executable._rollup,
+      arguments = [
+        # TODO(i): how to get this path in a proper way?!?!?


@alexeagle can you please advise?

IgorMinar · 2018-01-13T09:29:49Z

packages/bazel/src/ng_package.bzl

+  license_banner = ''
+  if (license_banner_file != None):
+    # TODO(i): read the file to string for realzzz!!!!
+    license_banner = str(license_banner_file);


@alexeagle how does one read contents of a file? is that even possible? I'm guessing that the file doesn't even exist yet when this code is executing, but there surely must be a way to read a text file into a string.. no?

or is my only option to create a shell script or nodejs binary and read the file there?

ctx.actions.template_file or so

I think you meant https://docs.bazel.build/versions/master/skylark/lib/actions.html#expand_template but the problem with that is that the output is a File not a string. I think what I was trying to do is fundamentally incompatible with how bazel works - I can't read a file within the code of an action. I have to write an executable to do that or use a run_shell instead. I'll try run_shell first.

IgorMinar · 2018-01-14T22:13:31Z

packages/bazel/src/ng_package.bzl

+      outs = ["%s_package.stamped.json" % name],
+      stamp = True,
+      cmd = "sed \"s/0.0.0-PLACEHOLDER/$$(grep BUILD_SCM_HASH bazel-out/volatile-status.txt | cut -d' ' -f 2)/\" $< > $@",


uhh.. this seems gross. isn't there a better way to do this?

alexeagle · 2018-01-16T14:07:37Z

integration/ng_package/BUILD.bazel

+# TODO(i): move ng_package with all tests and source code into a separate directory within packages/bazel
+#   this will require:
+#     - moving things around within packages/bazel/src
+#     - getting rid of the nested workspace so that we can use //packages/core:package to test against


not necessarily, the workspaces are peers. From packages/bazel you can depend on @angular_src// - we already do this so that the ng_module implementation can reference compiler-cli

I tried that but got weird errors from within the label (I was able to invoke the label, but the label failed to execute when invoked in this way - I didn't debug it)

alexeagle · 2018-01-16T14:08:41Z

integration/ng_package/BUILD.bazel

+    srcs = glob(["*.ts"]),
+    tsconfig = ":tsconfig.json",
+    # TODO(i): this doesn't work - I can't seem to be able to reference this label..
+    #   Maybe it's because the npm_install happens via the weird WORKSPACE setup function?


is it @bazel_ng_package_deps//... ?

why @? I'd expect it to be @angular_src//:bazel_ng_package_deps or :bazel_ng_package_deps. are all labels created via WORKSPACE prefixed with @ or what?

alexeagle · 2018-01-16T14:13:13Z

packages/common/BUILD.bazel

+)
+
+ng_package_entry_point(
+    name = "http",


all this repetition sucks. can't we just provide the map once as the union of all these entries?
If we need to trim it for each entry point, can't we do this in the action?
then we don't need ng_package_entry_point rule

yeah. I'm not happy about it. this is already way better than what Chuck had in his branch. +1 for streamlining this more.

alexeagle · 2018-01-16T14:13:56Z

packages/common/http/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])

-load("@build_bazel_rules_typescript//:defs.bzl", "ts_library")
+load("@angular//:index.bzl", "ng_module")


we should generally load from //tools:defaults.bzl so everything in the repo is built with the one tsconfig the editor sees

oh. I need to rebase to get defaults.bzl

alexeagle · 2018-01-16T14:14:57Z

tools/bazel.rc

+# Release support             #
+###############################
+
+build --workspace_status_command=./tools/bazel_stamp_vars.sh


note for me: we need to test with --nostamp to make sure it doesn't blow up

can you explain?

mary-poppins · 2018-01-20T00:35:02Z

You can preview b350a6e at https://pr21431-b350a6e.ngbuilds.io/.

mary-poppins · 2018-01-20T06:13:41Z

You can preview 80f71f7 at https://pr21431-80f71f7.ngbuilds.io/.

mary-poppins · 2018-01-20T09:53:34Z

You can preview 8288bdf at https://pr21431-8288bdf.ngbuilds.io/.

mary-poppins · 2018-01-21T05:34:19Z

You can preview d266b67 at https://pr21431-d266b67.ngbuilds.io/.

IgorMinar · 2018-01-21T05:45:38Z

the esm5 build fails with:

21:25 $ bazel build //packages/core:package
INFO: Analysed target //packages/core:package (33 packages loaded).
INFO: Found 1 target...
INFO: From Angular Packaging: rolling up package:

bazel-out/darwin-fastbuild/bin/packages/core/package.es6/packages/core/testing/index.js → bazel-out/darwin-fastbuild/bin/packages/core/fesm2015-testing/testing.js...
created bazel-out/darwin-fastbuild/bin/packages/core/fesm2015-testing/testing.js in 286ms
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/index.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/index.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/index.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/public_api.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/public_api.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/public_api.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/async.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/async.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/async.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/async_test_completer.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/async_test_completer.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/async_test_completer.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/before_each.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/before_each.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/before_each.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/component_fixture.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/component_fixture.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/component_fixture.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/fake_async.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/fake_async.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/fake_async.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/lang_utils.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/lang_utils.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/lang_utils.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/logger.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/logger.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/logger.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/metadata_override.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/metadata_override.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/metadata_override.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/ng_zone_mock.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/ng_zone_mock.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/ng_zone_mock.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/private_export_testing.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/private_export_testing.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/private_export_testing.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/test_bed.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/test_bed.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/test_bed.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/test_compiler.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/test_compiler.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/test_compiler.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/testing.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/testing.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/testing.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/testing_internal.ngfactory.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/testing_internal.ngsummary.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: output 'packages/core/testing/testing.es5_esm/packages/core/testing/src/testing_internal.js' was not created
ERROR: /Users/iminar/Dev/angular/packages/core/testing/BUILD.bazel:5:1: not all outputs were created or valid
Target //packages/core:package failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 49.774s, Critical Path: 42.95s
FAILED: Build did NOT complete successfully

I haven't debugged this yet. I'll try tomorrow.

@alexeagle does this look familiar? your branch gave me the same error before I cherry-picked it over.

ngbot · 2018-01-24T00:56:02Z

Hi @IgorMinar! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

mary-poppins · 2018-01-24T05:14:04Z

You can preview d673a71 at https://pr21431-d673a71.ngbuilds.io/.

mary-poppins · 2018-02-06T22:23:00Z

You can preview 96f6f2f at https://pr21431-96f6f2f.ngbuilds.io/.

mary-poppins · 2018-02-08T01:24:24Z

You can preview 080156b at https://pr21431-080156b.ngbuilds.io/.

ngbot · 2018-02-12T18:18:08Z

Hi @IgorMinar! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

ngbot · 2018-02-12T18:18:56Z

Hi @IgorMinar! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

ngbot · 2018-02-12T18:19:07Z

Hi @IgorMinar! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

ngbot · 2018-02-13T19:42:15Z

Hi @IgorMinar! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

ngbot · 2018-02-13T19:44:20Z

Hi @IgorMinar! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

alexeagle · 2018-02-13T19:57:32Z

landing a rebased subset of this in #22176

alexeagle · 2018-03-19T15:40:47Z

Obsolete; ng_package landed a few releases ago

angular-automatic-lock-bot · 2019-09-13T10:52:05Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jan 10, 2018

kara added the area: build & ci Related the build and CI infrastructure of the project label Jan 10, 2018

IgorMinar added the action: merge The PR is ready for merge by the caretaker label Jan 12, 2018

IgorMinar removed the action: merge The PR is ready for merge by the caretaker label Jan 12, 2018

IgorMinar commented Jan 13, 2018

View reviewed changes

IgorMinar commented Jan 14, 2018

View reviewed changes

IgorMinar force-pushed the build/ng_package branch from 798113a to ac9bbf9 Compare January 14, 2018 22:30

alexeagle reviewed Jan 16, 2018

View reviewed changes

angular deleted a comment from ngbot bot Jan 16, 2018

IgorMinar force-pushed the build/ng_package branch from 4959b19 to b350a6e Compare January 20, 2018 00:25

IgorMinar force-pushed the build/ng_package branch from b350a6e to 80f71f7 Compare January 20, 2018 06:05

IgorMinar force-pushed the build/ng_package branch from 80f71f7 to 8288bdf Compare January 20, 2018 09:38

IgorMinar mentioned this pull request Jan 21, 2018

WIP: can almost build es5-esm JS files IgorMinar/angular#3

Closed

3 tasks

IgorMinar force-pushed the build/ng_package branch from e31c196 to d673a71 Compare January 24, 2018 05:06

alexeagle and others added 11 commits February 6, 2018 11:38

wip: don't hoist metadata files

d743280

wip: add uglify, refactor helpers to return their outputs

d5addf3

wip: produce the umd.bin.js files

2f3a155

wip: add core-testing bundles

0d5bef1

wip: fix the secondary entry points in fesm directories

af1404f

wip: fix the common package

6a76cce

wip: add top level redirects for secondary entry points

4fe07b9

wip: turn off tsickle for es5_esm

6cef9d5

wip: remove ng_package_entry_point rule

a70a289

wip: make secondary_entry_points relative

a94d36e

wip: rebase on master; refactor out esm5 aspect

96f6f2f

alexeagle force-pushed the build/ng_package branch from b94ab77 to 96f6f2f Compare February 6, 2018 22:15

alexeagle added 3 commits February 7, 2018 08:38

wip: refactor stamping so it doesn't require a macro

c6be830

wip: refactor to share ROLLUP_ATTRS

1927acb

wip: pick up rules_nodejs fix

080156b

IgorMinar mentioned this pull request Feb 8, 2018

test: add script to check embedded source-maps correctness #16574

Closed

3 tasks

IgorMinar added the feature Issue that requests a new feature label Feb 9, 2018

build: better error handling and messages for bazel_stamp_vars.sh

c724e7d

alexeagle closed this Mar 19, 2018

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

WIP: initial version of ng_package #21431

WIP: initial version of ng_package #21431

Conversation

IgorMinar commented Jan 10, 2018

mary-poppins commented Jan 10, 2018

mary-poppins commented Jan 10, 2018

mary-poppins commented Jan 10, 2018

mary-poppins commented Jan 10, 2018

IgorMinar commented Jan 10, 2018

alexeagle commented Jan 10, 2018 via email

ngbot bot commented Jan 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mary-poppins commented Jan 20, 2018

mary-poppins commented Jan 20, 2018

mary-poppins commented Jan 20, 2018

mary-poppins commented Jan 21, 2018

IgorMinar commented Jan 21, 2018 • edited Loading

ngbot bot commented Jan 24, 2018

mary-poppins commented Jan 24, 2018

mary-poppins commented Feb 6, 2018

mary-poppins commented Feb 8, 2018

ngbot bot commented Feb 12, 2018

ngbot bot commented Feb 12, 2018

ngbot bot commented Feb 12, 2018

ngbot bot commented Feb 13, 2018

ngbot bot commented Feb 13, 2018

alexeagle commented Feb 13, 2018

alexeagle commented Mar 19, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019

IgorMinar commented Jan 21, 2018 •

edited

Loading