fix(forms): fix radio button select timing

[kara]

This PR ensures that if radio button controls are removed programmatically before their value accessors can be destroyed, they don't break the registry's selection logic.

Before

<input type="radio" [formControl]="showRadio" value="yes">
<input type="radio" [formControl]="showRadio" value="no">
<form [formGroup]="form">
   <div *ngIf="showRadio.value === 'yes'">
      <input type="radio" formControlName="food" value="chicken">
      <input type="radio" formControlName="food" value="fish">
   </div>
</form>

class MyComp {
   showRadio = new FormControl('yes');
   form = new FormGroup({
       'food': new FormControl('chicken')
   });

   constructor() {
      this.showRadio.valueChanges.subscribe((change) => {
         (change === 'yes') ? this.add() : this.remove());
      });
   }

   add() {
       this.form.addControl('food', new FormControl('chicken'));
   }

   remove() {
      // must process this next tick to avoid undefined control error from value accessor
      setTimeout(() => this.form.removeControl('food));
   }

}

After

   remove() {
      // don't need timeout
      this.form.removeControl('food');
   }

[vsavkin]

const

[kara]

You got me!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}