Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Headers): serializable toJSON #6714

Closed
wants to merge 1 commit into from
Closed

fix(Headers): serializable toJSON #6714

wants to merge 1 commit into from

Conversation

PatrickJS
Copy link
Member

fixes #6073

@PatrickJS PatrickJS mentioned this pull request Jan 27, 2016
Closed
@PatrickJS PatrickJS force-pushed the headers-to-json branch 4 times, most recently from 45fd831 to 43cb8bb Compare January 27, 2016 07:24
@hansl
Copy link
Contributor

hansl commented Feb 1, 2016

Could you rebase this CL over master please?

@hansl
Copy link
Contributor

hansl commented Feb 1, 2016

LGTM, with the caveat that the dart_ddc test passes.

@PatrickJS
Copy link
Member Author

@hansl I rebased, I'm not sure why dart_ddc fails

@hansl hansl added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Feb 1, 2016
@hansl
Copy link
Contributor

hansl commented Feb 1, 2016

Okay Dart DDC just passed. I'm going to stamp this. Good work!

@PatrickJS
Copy link
Member Author

kool, thanks

@mary-poppins
Copy link

Merging PR #6714 on behalf of @alexeagle to branch presubmit-alexeagle-pr-6714.

@mhevery mhevery closed this in b55f176 Feb 3, 2016
@PatrickJS PatrickJS deleted the headers-to-json branch February 3, 2016 15:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP Headers .toJSON() only returns values (not keys) of the headers
5 participants
@PatrickJS @hansl @mary-poppins @alexeagle @googlebot