feat(animate): cross-browser compatibility #4243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marclaval
force-pushed
the
fixAnimation
branch
from
8b18607
to
600e938
Compare
|
let me know when it is ready for review |
marclaval
force-pushed
the
fixAnimation
branch
6 times, most recently
from
51e5cd2
to
ab32c35
Compare
marclaval
added
action: review
|
Ready for review /cc @robertmesserle |
|
|
||
| //RequestAnimationFrame (IE9, Android 4.1, 4.2, 4.3) | ||
| /*! @author Paul Irish */ | ||
| /*! @source https://gist.github.com/paulirish/1579671 */ |
There was a problem hiding this comment.
It would be nice if we can use a node module or a github repo, in case someone fixes some bugs on it, etc. No worries if you can't find any.
|
I thought this also broke during the traceur removal. Now I see that it is independent issue with animation, so I will let @robertmesserle do the final review. LGTM from my standpoint. |
marclaval
force-pushed
the
fixAnimation
branch
from
ab32c35
to
5341267
Compare
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #4219, only the last 2 commits have to be reviewed.