feat(http): xhr error listener invokes onError

[PatrickJS]

    this._xhr.addEventListener('error', (err) => {
      var responseOptions = new ResponseOptions({body: err, type: ResponseTypes.Error});
      if (isPresent(baseResponseOptions)) {
        responseOptions = baseResponseOptions.merge(responseOptions);
      }
      ObservableWrapper.callThrow(this.response, new Response(responseOptions))
    });

[tbosch]

This looks good, but we need a test...

[PatrickJS]

alright I rebased, refactored, and added a test.

[PatrickJS]

oops I was cleaning up old branches and accidently deleted this

[jeffbcross]

By setting the type to ResponseTypes.Error on this ResponseOptions object, you're setting the default type to be Error, which is bad for the test, since we want to test that XHRBackend is smart enough to set the type as error based on the xhr erroring or getting a status that is considered an error.

[tbosch]

@jeffbcross ping...

[jeffbcross]

@gdi2290 finally scheduled this to be merged, thanks! https://github.com/angular/angular/tree/presubmit-jeffbcross-pr-2667

[PatrickJS]

thanks!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}