fix(compiler): report a reasonable error with invalid metadata #20062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler would throw an internal exception if an import using the `ngModule` syntax and the module as not a resolvable symbol. Fixes: angular#20049
|
You can preview 01c2202 at https://pr20062-01c2202.ngbuilds.io/. |
tbosch
approved these changes
Oct 31, 2017
chuckjaz
added
PR target: TBD
action: merge
|
CARETAKER: This PR is ready to merge but should be merged after |
|
@chuckjaz what is TBD ? 5.x and 5.0.x ? |
chuckjaz
added
target: patch
vicb
pushed a commit
that referenced
this pull request
Nov 6, 2017
The compiler would throw an internal exception if an import using the `ngModule` syntax and the module as not a resolvable symbol. Fixes: #20049
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler would throw an internal exception if an import using
the
ngModulesyntax and the module as not a resolvable symbol.Fixes: #20049
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #20049
The compiler would throw an internal exception when importing a module that could not be resolved.
What is the new behavior?
The compiler produces more reasonable error message.
Does this PR introduce a breaking change?