Perf compiler typecheck #19152
Perf compiler typecheck #19152
Conversation
|
You can preview 6e7275b at https://pr19152-6e7275b.ngbuilds.io/. |
tbosch
force-pushed
the
perf_typecheck
branch
from
6e7275b
to
4c37f77
Compare
|
You can preview 4c37f77 at https://pr19152-4c37f77.ngbuilds.io/. |
tbosch
force-pushed
the
perf_typecheck
branch
from
4c37f77
to
052b1e7
Compare
|
You can preview 052b1e7 at https://pr19152-052b1e7.ngbuilds.io/. |
| @@ -21,6 +21,14 @@ export interface Diagnostic { | |||
| source: 'angular'; | |||
| } | |||
|
|
|||
| export function isTsDiagnostic(diagnostic: any): diagnostic is ts.Diagnostic { | |||
| return diagnostic && diagnostic.source != 'angular'; | |||
There was a problem hiding this comment.
should return a boolean (same below)
There was a problem hiding this comment.
also use !== for consistency while you're at it
|
You can preview 84c69ce at https://pr19152-84c69ce.ngbuilds.io/. |
| private actions: Expression[] = []; | ||
|
|
||
| constructor( | ||
| private _options: AotCompilerOptions, private reflector: StaticReflector, |
There was a problem hiding this comment.
nit: why _ only for one field ? remove ?
There was a problem hiding this comment.
Removed all _ in this file...
tbosch
force-pushed
the
perf_typecheck
branch
from
84c69ce
to
3c8290b
Compare
|
You can preview 3c8290b at https://pr19152-3c8290b.ngbuilds.io/. |
tbosch
force-pushed
the
perf_typecheck
branch
2 times, most recently
from
136ee51
to
e6387aa
Compare
|
You can preview 136ee51 at https://pr19152-136ee51.ngbuilds.io/. |
|
You can preview e6387aa at https://pr19152-e6387aa.ngbuilds.io/. |
tbosch
force-pushed
the
perf_typecheck
branch
from
e6387aa
to
f2e64c0
Compare
|
You can preview f2e64c0 at https://pr19152-f2e64c0.ngbuilds.io/. |
tbosch
added
area: core
tbosch
force-pushed
the
perf_typecheck
branch
from
f2e64c0
to
da29984
Compare
|
You can preview da29984 at https://pr19152-da29984.ngbuilds.io/. |
…ing. This speeds up the compilation process significantly. Also introduces a new option `fullTemplateTypeCheck` to do more checks in templates: - check expressions inside of templatized content (e.g. inside of `<div *ngIf>`). - check the arguments of calls to the `transform` function of pipes - check references to directives that were exposed as variables via `exportAs`
tbosch
force-pushed
the
perf_typecheck
branch
from
da29984
to
6cfdd35
Compare
|
You can preview 6cfdd35 at https://pr19152-6cfdd35.ngbuilds.io/. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.