-
Notifications
You must be signed in to change notification settings - Fork 25.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Remove ChangeDetectorRef Paramter from KeyValueDifferFactory and IterableDifferFactory #14311
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
I attempted to preserve existing functionality but it was tricky and I am not sure if that is the correct way to overload the first paramter. |
@mhevery btw why did this pr pass CI if commit messages don't follow the guidelines? |
The message checking are disabled but we should have them enabled soon.
…On Thu, Feb 9, 2017 at 12:12 PM, Dzmitry Shylovich ***@***.*** > wrote:
@mhevery <https://github.com/mhevery> btw why did this pr pass CI if
commit messages don't follow the guidelines?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14311 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAG1T9GvFqc7jzPy5hBpQ3mo_FSAA6pwks5ra3NJgaJpZM4L3kOr>
.
|
…ry and IterableDifferFactory (angular#14311) BREAKING CHANGE: - `KeyValueDifferFactory` and `IterableDifferFactory` no longer have `ChangeDetectorRef` as a parameter. It was not used and has been there for historical reasons. If you call `DifferFactory.create(...)` remove the `ChangeDetectorRef` argument.
…ry and IterableDifferFactory (angular#14311) BREAKING CHANGE: - `KeyValueDifferFactory` and `IterableDifferFactory` no longer have `ChangeDetectorRef` as a parameter. It was not used and has been there for historical reasons. If you call `DifferFactory.create(...)` remove the `ChangeDetectorRef` argument.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
#13961: DifferFactories required a ChangeDetectorRef to be passed into it's create method but did not use it.
What is the new behavior?
The ChangeDetectorRef parameter has been removed from the create method and it's arguments have been removed from places that use it.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Applications that have used the Iterable factory will
Other information: