Update to [email protected] and unpin the rxjs peerDependency #13561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that rxjs is stable and the rxjs team follows semver, we can update and unpin the dependency safely. From now on the Angular application/library developers are in charge of controlling the rxjs version as long as it's newer than 5.0.1.
IgorMinar
added
action: review
vicb
reviewed
Dec 19, 2016
| @@ -23,7 +23,7 @@ | |||
| "rollup-plugin-node-resolve": "^1.5.0", | |||
| "rollup-plugin-typescript": "^0.7.3", | |||
| "rollup-plugin-uglify": "^0.3.1", | |||
| "rxjs-es": "^5.0.0-rc.4", | |||
There was a problem hiding this comment.
rxjs-es ?
Seems outdated, is this folder still used at all ?
There was a problem hiding this comment.
it's not. we should really remove this whole directory, but I didn't want to do it in this PR.
vicb
pushed a commit
to vicb/angular
that referenced
this pull request
Dec 19, 2016
Now that rxjs is stable and the rxjs team follows semver, we can update and unpin the dependency safely. From now on the Angular application/library developers are in charge of controlling the rxjs version as long as it's newer than 5.0.1. closes angular#13561 closes angular#13478 closes angular#13572
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.