Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add a provider making angular1/angular2 integration easier #12769

Merged
merged 1 commit into from
Nov 9, 2016

Conversation

vsavkin
Copy link
Contributor

@vsavkin vsavkin commented Nov 8, 2016

Closes #12690

@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Nov 8, 2016
@vikerman
Copy link
Contributor

vikerman commented Nov 8, 2016

@vsavkin - e2e test failures

@vsavkin vsavkin force-pushed the wire_up_location_change_listener branch from 5f28cc1 to ad5b205 Compare November 9, 2016 00:11
@vikerman vikerman merged commit 6e35d13 into angular:master Nov 9, 2016
@poke
Copy link

poke commented Nov 15, 2016

With this change, the router now requires @angular/upgrade as a peer dependency, even if Angular 1 integration is not required by the project. Was this an intentional choice? Isn’t this conflicting with the modular idea that you only need to import those modules you actually need for your project?

@poke
Copy link

poke commented Nov 24, 2016

Okay, this was also reported as #12895 and fixed with #12896.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng1/ng2 dual router setup does not properly transition from ng1->ng2 pages when HTML5 navigation is enabled
5 participants