fix(animations): ensure animations work with web-workers #12656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matsko please add labels to your PRs |
matsko
force-pushed
the
animation_workers
branch
from
725a0e4 to
1a27d6e
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 3, 2016
matsko
force-pushed
the
animation_workers
branch
from
1a27d6e to
57fd9bc
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 3, 2016
matsko
force-pushed
the
animation_workers
branch
from
57fd9bc to
ab0ea10
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 3, 2016
matsko
force-pushed
the
animation_workers
branch
from
ab0ea10 to
2e4b595
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 3, 2016
matsko
added
the
action: review
matsko
force-pushed
the
animation_workers
branch
from
2e4b595 to
5d5697a
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 3, 2016
tbosch
reviewed
Nov 3, 2016
| ], | ||
| this._animate.bind(this)); | ||
|
|
||
| // |
There was a problem hiding this comment.
maybe move these into a method so that the grouping is clear, i.e. then you don't need this comment.
tbosch
reviewed
Nov 3, 2016
| ]); | ||
|
|
||
| const player = new _AnimationWorkerRendererPlayer(this._rootRenderer, renderElement); | ||
| this._rootRenderer.renderStore.store(player, playerId); |
There was a problem hiding this comment.
Where are you removing the animation players from the renderStore again?
tbosch
reviewed
Nov 3, 2016
| renderer: Renderer, element: any, startingStyles: any, keyframes: any[], duration: number, | ||
| delay: number, easing: string, playerId: any) { | ||
| var player = renderer.animate(element, startingStyles, keyframes, duration, delay, easing); | ||
| this._renderStore.store(player, playerId); |
There was a problem hiding this comment.
Where are you removing the animation player from the renderStore again (ui side)?
tbosch
reviewed
Nov 3, 2016
| export class WebWorkerRenderNode { events: NamedEventEmitter = new NamedEventEmitter(); } | ||
| export class WebWorkerRenderNode { | ||
| events = new NamedEventEmitter(); | ||
| animationPlayers = new AnimationPlayerEmitter(); |
There was a problem hiding this comment.
rename property to animationPlayerEvents
tbosch
reviewed
Nov 3, 2016
| } | ||
|
|
||
|
|
||
| @Component({ |
There was a problem hiding this comment.
Could you create 1 e2e test as well that does a simple animation with webworkers?
tbosch
added
action: cleanup
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 3, 2016
matsko
force-pushed
the
animation_workers
branch
from
5d5697a to
c23a32c
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 4, 2016
matsko
force-pushed
the
animation_workers
branch
from
c23a32c to
ada7407
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 4, 2016
matsko
force-pushed
the
animation_workers
branch
from
ada7407 to
ef1779b
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 5, 2016
matsko
force-pushed
the
animation_workers
branch
from
ef1779b to
5029246
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 5, 2016
matsko
force-pushed
the
animation_workers
branch
from
5029246 to
45cad2c
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 7, 2016
matsko
force-pushed
the
animation_workers
branch
from
45cad2c to
7f19ede
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 7, 2016
matsko
force-pushed
the
animation_workers
branch
from
7f19ede to
9c0438b
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 7, 2016
matsko
force-pushed
the
animation_workers
branch
from
9c0438b to
4ccadff
Compare
matsko
added a commit
to matsko/angular
that referenced
this pull request
Nov 8, 2016
matsko
force-pushed
the
animation_workers
branch
3 times, most recently
from
5326770 to
6865fa1
Compare
matsko
changed the title
matsko
force-pushed
the
animation_workers
branch
from
6865fa1 to
bf6fa94
Compare
tbosch
added
pr_state: LGTM
and removed
action: cleanup
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.