Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): ignore null or undefined query parameters #12333

Merged
merged 1 commit into from
Nov 10, 2016
Merged

fix(router): ignore null or undefined query parameters #12333

merged 1 commit into from
Nov 10, 2016

Conversation

DzmitryShylovich
Copy link
Contributor

Fixes #7543

@DzmitryShylovich DzmitryShylovich force-pushed the feature/7543 branch 5 times, most recently from d31a761 to bf6583a Compare October 16, 2016 22:59
@vicb vicb added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker pr_state: LGTM labels Oct 16, 2016
vicb
vicb reviewed Oct 16, 2016
View reviewed changes
modules/@angular/router/src/router.ts
@@ -520,11 +523,21 @@ export class Router {
if (url instanceof UrlTree) {
return containsTree(this.currentUrlTree, url, exact);
} else {
const urlTree = this.urlSerializer.parse(url);
const urlTree = this.urlSerializer.parse(<string>url);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

vicb
vicb reviewed Oct 16, 2016
View reviewed changes
modules/@angular/router/src/router.ts
@@ -500,6 +500,9 @@ export class Router {
*/
navigate(commands: any[], extras: NavigationExtras = {skipLocationChange: false}):
Promise<boolean> {
if (typeof extras.queryParams === 'object') {
Copy link
Contributor

@vicb vicb Oct 16, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& !== null

@vicb vicb added action: review The PR is still awaiting reviews from at least one requested reviewer area: router labels Oct 17, 2016
@vsavkin vsavkin added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 19, 2016
@alxhub alxhub added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Oct 20, 2016
@alxhub
Copy link
Member

alxhub commented Oct 20, 2016

@DzmitryShylovich can you rebase this please? Thanks :)

@DzmitryShylovich
Copy link
Contributor Author

@alxhub done

@pkozlowski-opensource pkozlowski-opensource removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 10, 2016
@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Nov 10, 2016
@vicb vicb merged commit 3052fb2 into angular:master Nov 10, 2016
@DzmitryShylovich DzmitryShylovich deleted the feature/7543 branch November 27, 2016 18:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vicb vicb vicb left review comments

Assignees

@DzmitryShylovich DzmitryShylovich

Labels
action: merge The PR is ready for merge by the caretaker area: router cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make router ignore null or undefined optional parameters
6 participants
@DzmitryShylovich @alxhub @vicb @vsavkin @pkozlowski-opensource @googlebot