fix(ShadowCss): properly shim selectors after :host and :host-context #10997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
added
comp: core/view
action: review
fixes angular#5390 Before the change: // original CSS :host .foo .bar {...} .foo .bar {...} // translated to [_nghost-shh-2] .foo .bar {...} .foo[_ngcontent-shh-2] .bar[_ngcontent-shh-2] {...} Note that `.foo` and `.bar` where not scoped and would then apply to nested components. With this change those selectors are scoped (as they are without `:host`). You can explicitly apply the style to inner component by using `>>>` or `/deep/`: `:host >>> .foo`
IgorMinar
added
pr_state: LGTM
action: merge
|
blocked on g3 update |
vicb
added
action: merge
This was referenced Aug 28, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.