feat(router): extend support for lazy loading children

[vsavkin]

Closes #10659

[robwormald]

LGTM

[hansl]

LGTM as well.

[sirajc]

@brandonroberts This will help in simplification of your AsyncNgModuleLoader, I think

[brandonroberts]

Yep. It actually removes the need for it which is great. Now you can
provide your bundlers method to import through a function that returns a
promise.

On Aug 11, 2016 5:13 PM, "Sirajuddin Choudhary" [email protected]
wrote:

@brandonroberts https://github.com/brandonroberts This will help in
simplification of your AsyncNgModuleLoader, I think

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10705 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACk4xLnZgDs1YdSft4LOuGpVmASTTWdks5qe56MgaJpZM4JiiAZ
.

[vikerman]

TAP Blocked

[ocombe]

ohhh does this mean that we can use webpack to generate bundles on its own again with the router ?

[brandonroberts]

@ocombe yep. No longer need a custom loader for webpack support.

[seveves]

Can I see this in action anywhere?

[ocombe]

In webpack it's as simple as:

const routerConfig: Routes = [{
  path: '',
  loadChildren: () => System.import('./Home').then(({HomeModule}) => HomeModule)
}]

⚠️ I don't know how this will work with AoT compilation

[seveves]

@ocombe thank you but now it says "System is not defined" ... do I need to do any changes to my webpack config?

[ocombe]

Ah my bad, System is only available in webpack 2, if you're using webpack 1 you can do:

const routerConfig: Routes = [{
  path: '',
  loadChildren: () => new Promise(resolve => {
      require.ensure([], require => {
        resolve(require('./Home').HomeModule);
      })
    })
}]

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}