Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

$AnimateProvider "enter" method bug #8434

Closed
jirikuchta opened this issue Jul 31, 2014 · 3 comments
Closed

$AnimateProvider "enter" method bug #8434

jirikuchta opened this issue Jul 31, 2014 · 3 comments

Comments

@jirikuchta
Copy link

The "enter" method in $AnimateProvider throws an error if no "after" parameter is passed and "parent" parameter is an empty element.

Here is what the method looks like:

function(element, parent, after, done) {
   if (after) {
      after.after(element);
   } else {
      if (!parent || !parent[0]) {
         parent = after.parent();
      }
      parent.append(element);
   }
   async(done);
}

The inner condition throws an error because "after" element is never defined (it is eliminated by the preceding condition).

I am not sure what the right behavior should be so I don't propose any fix.

@petebacondarwin
Copy link
Member

Can you provide a scenario where you call enter in this way so that we can ascertain what the best fix should be? A working Plunker would be ideal.

@caitp
Copy link
Contributor

caitp commented Aug 1, 2014

This sounds suspiciously like #6275 --- but matias fixed that one

@jirikuchta
Copy link
Author

Yep, it seems I did a bad work when searching through existing issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants