This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(jqLite): properly toggle multiple classes #6448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange, TravisCI gets upset while Jenkins is quite happy: |
|
@pkozlowski-opensource there was an issue with dgeni, that's why travis got upset. |
|
|
||
| it('should allow toggling multiple classes without a condition', function () { | ||
| var selector = jqLite([a, b]); | ||
| expect(selector.toggleClass('abc cde')).toEqual(selector); |
There was a problem hiding this comment.
always use toBe instead of toEqual unless you mean it.
|
please make the requested changes and merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl could be approached differently, I guess, but yeh, the issue is here as demonstrated by tests.
Fixes #4467