-
Notifications
You must be signed in to change notification settings - Fork 27.5k
make $location getters easily observable #643
Comments
since the $location functions determine whether the getter or setter is being called by checking if the first argument is |
@colincasey - you are right. For the "properties" that are "Getter-Setter": Probably makes this idea much less trivial |
@petebacondarwin, definitely less trivial. i played around with this for awhile yesterday and was able to get the function bindings for all the location properties to work with the only other way i could think to make this work would be to also check the first argument to see if it was a |
I wonder if it is any real benefit to spend time on this. It is only syntactic sugar and also $watch will be moving towards using |
if we removed
this
references from $location getters, we could writescope.$watch($location.url, ..)
instead ofscope.$watch(function() { return $location.url() }, ...)
this should be a trivial change
The text was updated successfully, but these errors were encountered: