Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(doc-gen): Run Gulp on Windows too #6346

Closed
wants to merge 2 commits into from
Closed

fix(doc-gen): Run Gulp on Windows too #6346

wants to merge 2 commits into from

Conversation

panarasi
Copy link

Using node_module/.bin/gulp will enable to gulp command to run
both on Windows and Linux. In its current form, opening a Javascript
file on Windows will not run the doc generation.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6346)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@panarasi panarasi added cla: no and removed cla: yes labels Feb 19, 2014
Using node_module/.bin/gulp will enable to gulp command to run
both on Windows and Linux. In its current form, opening a Javascript
file on Windows will not run the doc generation.
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@panarasi panarasi added cla: yes and removed cla: no labels Feb 20, 2014
@davidjnelson davidjnelson self-assigned this Feb 22, 2014
@davidjnelson davidjnelson added this to the Backlog milestone Feb 22, 2014
@davidjnelson davidjnelson removed their assignment Feb 22, 2014
@davidjnelson
Copy link
Contributor

Thanks @panarasi this looks super useful.

@sjbarker
Copy link
Contributor

+1

Requires to correctly resolve path on Windows
@panarasi
Copy link
Author

panarasi commented Mar 4, 2014

@sjbarker Made the change.
Anything else stopping it from being merged in ?

@sjbarker
Copy link
Contributor

sjbarker commented Mar 5, 2014

@panarasi awesome! Unfortunately, I can only point that question to @mary-poppins. I would double-check and make sure that the checklist provided in the comment above has been completed and that you are sticking to the contributor guidelines. For example, you will want to roll the fix you made into a single commit and follow the commit format. This will ensure that all proper information is included in the release notes.

@michalliu
Copy link

bravo

@btford
Copy link
Contributor

btford commented Mar 25, 2014

@petebacondarwin can you look at this?

@petebacondarwin
Copy link
Member

On it.

matsko pushed a commit that referenced this pull request Mar 28, 2014
Using node_module/.bin/gulp will enable to gulp command to run
both on Windows and Linux. In its current form, the default action of
executing a Javascript file on Windows does not use node.
Requires quotes around the command to correctly resolve path on Windows

Closes #6346
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants